Show HN: I rewrote few of the common core string.h functions

deepvinci | 9 points

Depending on what exactly you are trying to learn from this, I would recommend looking at the source for musl like https://git.musl-libc.org/cgit/musl/tree/src/string and trying to understand why it looks so much more complicated than the simple implementation.

gthompson512 | 18 days ago

how do you know that the implementation is correct? i don't see tests

mparnisari | 18 days ago

`r_strlen` truncates the output length on 64bit systems (size_t is 64 bits while int is 32 bits).

You should be compiling with -Wall -Werror.

nemothekid | 18 days ago

If you specifically want code review, consider submitting the code to the code review SE https://codereview.stackexchange.com/

bsima | 18 days ago

I would rather see some novel, simple, easy to use c string library.

dvh | 18 days ago

strcmp doesn’t return a bool.

secondcoming | 18 days ago

Is this meant to be used in production systems, or is it just a learning exercise?

TheSoftwareGuy | 18 days ago